update the position of the tooltip and set it near the label text #12779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dharmik79
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
requested changes
Apr 24, 2024
src/components/FindWallet/WalletTable/WalletMoreInfoCategory.tsx
Outdated
Show resolved
Hide resolved
wackerow
reviewed
May 27, 2024
| @@ -87,20 +88,19 @@ export const WalletMoreInfoCategory = ({ | |||
| <ListIcon as={FeatureIcon}></ListIcon> | |||
|
|
|||
| <Text px={1} lineHeight={1}> | |||
| {feature.label} | |||
| {feature.label} | |||
There was a problem hiding this comment.
In either case, I would stick with either the non-breaking space, or the margin (ms="2" below) but not both... I'm still not sure of a clean way to do this for all browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the tooltip inside the feature label text and made the list item aligned horizontally [Fixes #12643]