Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zkSync Layer 2 purpose to "universal", description, and Logo #12798

Merged
merged 18 commits into from
May 7, 2024

Conversation

zk-Lumi
Copy link
Contributor

@zk-Lumi zk-Lumi commented Apr 23, 2024

Description

Updated zkSync purpose to "universal" + update description to meta description of website

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5b7da25
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/663a9e680898630008127a96
😎 Deploy Preview https://deploy-preview-12798--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 31 (🔴 down 8 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zk-Lumi zk-Lumi changed the title Update zkSync purpose to "universal" Update zkSync Layer 2 purpose to "universal" Apr 23, 2024
@github-actions github-actions bot added the translation 🌍 This is related to our Translation Program label Apr 23, 2024
@zk-Lumi zk-Lumi changed the title Update zkSync Layer 2 purpose to "universal" Update zkSync Layer 2 purpose to "universal" & description Apr 23, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zk-Lumi, appreciate this! To my understanding there is now zkSync Lite, and zkSync Era... the first one was the legacy one which was where this entry came from, and still exists (though seems to be transitioning out)

image image

If we're going to update this to use zkSync Era information, I think we should also update the name and logo to match. Let me know if I'm missing something or if you disagree.

@zk-Lumi
Copy link
Contributor Author

zk-Lumi commented Apr 25, 2024

Hey @zk-Lumi, appreciate this! To my understanding there is now zkSync Lite, and zkSync Era... the first one was the legacy one which was where this entry came from, and still exists (though seems to be transitioning out)

image image
If we're going to update this to use zkSync Era information, I think we should also update the name and logo to match. Let me know if I'm missing something or if you disagree.

Hi @wackerow,

For logo: Good point, I updated the logo to the newest branding.
For name: Lite is indeed being transitioned out and "Era" branding may or may not be phased out, so be good to keep name as "zkSync" for now.

@zk-Lumi zk-Lumi changed the title Update zkSync Layer 2 purpose to "universal" & description Update zkSync Layer 2 purpose to "universal", description, and Logo Apr 25, 2024
@zk-Lumi zk-Lumi requested a review from wackerow April 25, 2024 17:24
@zk-Lumi
Copy link
Contributor Author

zk-Lumi commented May 2, 2024

Ping on this @wackerow 🙏

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @zk-Lumi!

@wackerow wackerow merged commit e4f6ffb into ethereum:dev May 7, 2024
5 of 6 checks passed
Copy link

gitpoap-bot bot commented May 7, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

wackerow commented May 7, 2024

@all-contributors please add @zk-Lumi for maintenance

Copy link
Contributor

@wackerow

I've put up a pull request to add @zk-Lumi! 🎉

This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants