Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagrams to the dev docs /mev page #12826

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

sogobanwo
Copy link
Contributor

Add MEV diagrams to the diagrams page #12691

Description

Added an image showing how validators order transactions to get the MEV when proposing a block

Related Issue

(#12691)

Added an image showing how validators order transactions to get the MEV when proposing a block
@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Apr 24, 2024
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 35184aa
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6628d932f705a80008273e61
😎 Deploy Preview https://deploy-preview-12826--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 30
Accessibility: 93
Best Practices: 92
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@minimalsm minimalsm added the needs design approval 🧑‍🎨 Approval from a designer is needed before merging label Apr 24, 2024
@wackerow wackerow changed the title Update index.md Add diagrams to the dev docs /mev page May 7, 2024
@@ -20,6 +20,8 @@ In theory MEV accrues entirely to validators because they are the only party tha

Validators do get a portion of the full MEV amount anyway because searchers are willing to pay high gas fees (which go to the validator) in exchange for higher likelihood of inclusion of their profitable transactions in a block. Assuming searchers are economically rational, the gas fee that a searcher is willing to pay will be an amount up to 100% of the searcher's MEV (because if the gas fee was higher, the searcher would lose money).

![Screenshot from 2024-04-24 00-30-49](https://github.com/ethereum/ethereum-org-website/assets/99739569/a6a92c68-32db-4730-979b-0b2dae79b47a)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is discussion in-progress over on the issue (#12691) but when we do settle on a diagram, please note we should

  • Save and rename the image file inside public/content/developers/docs/mev/
  • Reference the file locally, without the "Screenshot" alt, ie: ![MEV Diagram](./mev-diagram.png)

Copy link
Contributor Author

@sogobanwo sogobanwo May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok no problems @wackerow when a conclusion is reach to settle for a diagram i will make a pull request to resolve this.
Thanks

@corwintines
Copy link
Member

Thanks @sogobanwo

Going to mark this as draft while the discussion resolves in the issue. When that is resolved, feel free to flip it back to ready for review :)

@corwintines corwintines marked this pull request as draft May 16, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits needs design approval 🧑‍🎨 Approval from a designer is needed before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants