Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance - contributors component refactor #12863

Merged
merged 5 commits into from
May 1, 2024

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented Apr 29, 2024

Description

Immediately display the contributors modal button to reduce LCP.

Other changes:

  • Used the MdChevronRight icon to match the initial close state and avoid the initial animation causing the LCP to be higher sometimes
  • Removed the Skeletons and add one inside the modal

====

Tests after changes

Webpagetest https://www.webpagetest.org/result/240430_BiDc8E_92E/

All the LCPs are the same now, ~2/3s.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8f62875
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6631073187ade200084bb1fd
😎 Deploy Preview https://deploy-preview-12863--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 30 (🔴 down 9 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip force-pushed the performance/mobile-dev-docs-contributors branch from 762d898 to 2630913 Compare April 30, 2024 06:57
@pettinarip pettinarip changed the title [TEST] performance - contributors component refactor Performance - contributors component refactor Apr 30, 2024
@pettinarip pettinarip marked this pull request as ready for review April 30, 2024 13:16
@nloureiro
Copy link
Contributor

yes, this is the temporary change we agreed on the other day.

Can I ask just to add the same spacing above and below the title?
I think it's var(--eth-space-8) between the title and the button

Screen Shot 2024-04-30 03 28 54 PM

@pettinarip
Copy link
Member Author

@nloureiro fixed

@minimalsm minimalsm merged commit ed3434e into dev May 1, 2024
10 checks passed
@minimalsm minimalsm deleted the performance/mobile-dev-docs-contributors branch May 1, 2024 08:21
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants