-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance - contributors component refactor #12863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
force-pushed
the
performance/mobile-dev-docs-contributors
branch
from
April 30, 2024 06:57
762d898
to
2630913
Compare
minimalsm
reviewed
Apr 30, 2024
minimalsm
reviewed
Apr 30, 2024
minimalsm
reviewed
Apr 30, 2024
…l state and avoid the initial animation
pettinarip
changed the title
[TEST] performance - contributors component refactor
Performance - contributors component refactor
Apr 30, 2024
minimalsm
approved these changes
Apr 30, 2024
@nloureiro fixed |
nloureiro
approved these changes
Apr 30, 2024
nhsz
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Immediately display the contributors modal button to reduce LCP.
Other changes:
====
Tests after changes
Webpagetest https://www.webpagetest.org/result/240430_BiDc8E_92E/
All the LCPs are the same now, ~2/3s.