Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors quiz callout banner #12908

Merged
merged 4 commits into from
May 7, 2024
Merged

Contributors quiz callout banner #12908

merged 4 commits into from
May 7, 2024

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented May 6, 2024

Description

Adds a banner for the contributor quiz to the `/contributing' page.

https://deploy-preview-12908--ethereumorg.netlify.app/en/contributing/

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits needs review 👀 labels May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 0a6d823
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/663a1609d389190008d42902
😎 Deploy Preview https://deploy-preview-12908--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🟢 up 11 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 95 (🔴 down 5 from production)
SEO: 95 (🔴 down 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.


import PplLearning from "@/public/ppl-learning.png"

// TODO: refactor to use CalloutBanner component
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from code side

public/ppl-learning.png Outdated Show resolved Hide resolved
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

image

Thanks @pettinarip!

@wackerow wackerow merged commit 9c05ee4 into dev May 7, 2024
9 of 10 checks passed
@wackerow wackerow deleted the contributor-quiz branch May 7, 2024 23:18
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants