Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sync existing stories with docs #12974

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

TylerAPfledderer
Copy link
Contributor

Description

Updates existing stories to be in sync with the current docs from applying-storybook.md

Copy link

netlify bot commented May 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 0e82cce
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/665aa4b4eda1e1000888accb
😎 Deploy Preview https://deploy-preview-12974--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🟢 up 11 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer marked this pull request as draft May 17, 2024 05:17
@TylerAPfledderer TylerAPfledderer marked this pull request as ready for review May 17, 2024 14:03
@TylerAPfledderer
Copy link
Contributor Author

@corwintines @pettinarip should be good to take a look!

@wackerow wackerow added config ⚙️ Changes to configuration files and removed internal 🏠 labels May 22, 2024
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @TylerAPfledderer sorry for the delay on this. There are a few conflicts. Once we fix them I think we are good to go.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙️ Changes to configuration files dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants