Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Waffle tutorial #1641

Merged
merged 12 commits into from
Nov 15, 2020
Merged

Add a new Waffle tutorial #1641

merged 12 commits into from
Nov 15, 2020

Conversation

duckception
Copy link
Contributor

@duckception duckception commented Oct 16, 2020

Description

Adds a new tutorial for Waffle about dynamic mocking and testing contract calls.

@github-actions github-actions bot added Status: Review Needed content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies labels Oct 16, 2020
@duckception duckception changed the title Add a new tutorial [WIP] Add a new Waffle tutorial Oct 16, 2020
@samajammin samajammin marked this pull request as draft October 21, 2020 17:35
@samajammin
Copy link
Contributor

Thanks for the submission @duckception! I've converted this PR to a "draft". Please let me know when it's complete & ready for review. Cheers!

@samajammin
Copy link
Contributor

Hey @duckception - checking in on this.

@duckception duckception changed the title [WIP] Add a new Waffle tutorial Add a new Waffle tutorial Nov 14, 2020
@duckception
Copy link
Contributor Author

Hey @samajammin. Sorry, it took so long. The PR is ready to be merged!

@duckception duckception marked this pull request as ready for review November 15, 2020 11:30
Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Made one edit.

@samajammin samajammin merged commit 7ecf4aa into ethereum:dev Nov 15, 2020
@duckception duckception deleted the test-ci branch November 16, 2020 09:53
@samajammin samajammin mentioned this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants