Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Waffle tutorial #1676

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Conversation

MiZiet
Copy link
Contributor

@MiZiet MiZiet commented Oct 25, 2020

Description

Add a new Hello World tutorial for Waffle.

@github-actions github-actions bot added Status: Review Needed content 🖋️ This involves copy additions or edits labels Oct 25, 2020
@samajammin samajammin marked this pull request as draft October 27, 2020 05:07
@samajammin
Copy link
Contributor

Thanks for the submission @MiZiet! I've converted this PR to a draft. Please mark it as ready for review when it's no longer a WIP.

@samajammin
Copy link
Contributor

Hey @MiZiet - checking in on this.

@samajammin
Copy link
Contributor

Hey @MiZiet - another nudge! We'd like to get this merged. Please let me know if/when this is ready to review. Thanks.

@MiZiet MiZiet changed the title [WIP] Add a new Waffle tutorial Add a new Waffle tutorial Nov 23, 2020
@MiZiet MiZiet marked this pull request as ready for review November 23, 2020 07:52
@MiZiet
Copy link
Contributor Author

MiZiet commented Nov 23, 2020

Hey, sorry that it took me so long.

Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the submission @MiZiet. Given that Buidler is now Hardhat, would you please update the tutorial to reflect that?

samajammin
samajammin previously approved these changes Nov 30, 2020
Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates! Approving w/ syntax tweaks.

@samajammin samajammin merged commit 1ad8a34 into ethereum:dev Nov 30, 2020
@samajammin
Copy link
Contributor

@all-contributors please add @MiZiet for content.

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @MiZiet! 🎉

@samajammin samajammin mentioned this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants