Added Optimistic rollups info #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs review 👀
samajammin
requested changes
Oct 31, 2020
There was a problem hiding this comment.
Solid start! Left a few comments that I think we should address before merging, primarily:
- Explaining the security models as the key differentiation between ZK & optimistic rollups
- Explaining that there's multiple implementation approaches within optimistic rollups
Co-authored-by: Sam Richards <sbrichards@gmail.com>
samajammin
previously approved these changes
Nov 11, 2020
samajammin
approved these changes
Nov 11, 2020
This was referenced Nov 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved our layer 2 docs by adding more information about optimistic rollups. This is based on extra context provided by Ben Jones' ETHOnline talk (https://youtu.be/96UfJPYyFcs?t=18863)
Related Issue
Relates to #774 but doesn't necessarily solve it.