Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth2 upgrades [wip] #1687

Merged
merged 124 commits into from
Nov 10, 2020
Merged

Eth2 upgrades [wip] #1687

merged 124 commits into from
Nov 10, 2020

Conversation

ryancreatescopy
Copy link
Contributor

Description

Redesign of the ETH2 section.

Related Issue

@ryancreatescopy ryancreatescopy added content 🖋️ This involves copy additions or edits design required 🎨 This involves design changes Type: Internal labels Oct 26, 2020
@samajammin samajammin marked this pull request as draft October 26, 2020 18:25
@@ -1,24 +1,32 @@
import React from "react"
import styled from "styled-components"
import Emoji from "./Emoji"
import { Twemoji } from "react-emoji-render"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @ryancreatescopy - moving forward, we only want to import Twemoji in our <Emoji />component. Everything else should import our <Emoji />component.

@samajammin
Copy link
Contributor

@ryancreatescopy I rebased with dev & pushed up updates mainly to

  1. move the pages under /eth2/ directory
  2. add eth2 template to support markdown upgrade pages
    You'll want to run git reset --hard origin/eth2-v2 before making any further changes in order to avoid conflicts.


The beacon chain’s role will change over time but it’s a foundational component for the secure, sustainable and scalable Ethereum we’re aiming towards.

The beacon chain isn’t like the Ethereum mainnet of today. It doesn’t have accounts and it can’t handle smart contracts. It’s role is to conduct or coordinate the network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/It's role/Its role

@github-actions github-actions bot added the translation 🌍 This is related to our Translation Program label Nov 2, 2020

export const query = graphql`
query {
rhino: file(relativePath: { eq: "eth2/eth2_rhino.png" }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryancreatescopy with the risk of getting too pedantic, let's keep the kebab-case convention for images (& all filenames), i.e. eth2-rino.png

@samajammin
Copy link
Contributor

FYI @ryancreatescopy see this commit on how to toggle images based on light/dark mode.

margin-bottom: 3rem;
`

const H2 = styled.h2`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryancreatescopy I see we re-use these H2 styles a bunch - can we move this into SharedStyledComponents? Should this replace our existing H2 already there?

@ryancreatescopy ryancreatescopy marked this pull request as ready for review November 10, 2020 17:18
samajammin
samajammin previously approved these changes Nov 10, 2020
Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT @ryancreatescopy please wait til build succeeds & confirm all looks good before merging.

@ryancreatescopy ryancreatescopy merged commit 76ab215 into dev Nov 10, 2020
@ryancreatescopy ryancreatescopy deleted the eth2-v2 branch November 10, 2020 18:23
@ryancreatescopy ryancreatescopy mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits design required 🎨 This involves design changes translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants