-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eth2 upgrades [wip] #1687
Eth2 upgrades [wip] #1687
Conversation
FYI @ryancreatescopy there's now the ability to open "draft" PRs. Let's get into the habit of that for WIP PRs: I've converted this one already 😄 |
@@ -1,24 +1,32 @@ | |||
import React from "react" | |||
import styled from "styled-components" | |||
import Emoji from "./Emoji" | |||
import { Twemoji } from "react-emoji-render" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @ryancreatescopy - moving forward, we only want to import Twemoji
in our <Emoji />
component. Everything else should import our <Emoji />
component.
@ryancreatescopy I rebased with
|
|
||
The beacon chain’s role will change over time but it’s a foundational component for the secure, sustainable and scalable Ethereum we’re aiming towards. | ||
|
||
The beacon chain isn’t like the Ethereum mainnet of today. It doesn’t have accounts and it can’t handle smart contracts. It’s role is to conduct or coordinate the network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/It's role/Its role
src/pages/eth2/get-involved.js
Outdated
|
||
export const query = graphql` | ||
query { | ||
rhino: file(relativePath: { eq: "eth2/eth2_rhino.png" }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryancreatescopy with the risk of getting too pedantic, let's keep the kebab-case convention for images (& all filenames), i.e. eth2-rino.png
FYI @ryancreatescopy see this commit on how to toggle images based on light/dark mode. |
margin-bottom: 3rem; | ||
` | ||
|
||
const H2 = styled.h2` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryancreatescopy I see we re-use these H2 styles a bunch - can we move this into SharedStyledComponents? Should this replace our existing H2 already there?
Users can use a service like infura or run their own node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT @ryancreatescopy please wait til build succeeds & confirm all looks good before merging.
Description
Redesign of the ETH2 section.
Related Issue