-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds glossary term content [contributes to #1718] #1725
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a02c96a
contributes to glossary #1718
wackerow 1afd919
updated defi, stablcoin, staking definitions
wackerow f0521c7
Changed gatekeeper to intermediaries
ryancreatescopy 43f142e
Merge branch 'dev' into w/glossary2
wackerow ec58225
refactored links to markdown
wackerow cc2f6dc
Update link to staking page
samajammin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can & should continue to use markdown syntax where possible.
Note: we can & should also drop the language path (/en/ in this case). When we use markdown links, Gatsby uses our Link component under the hood, which automatically adds the language path. This makes it easier when translating pages - we don't have to update the links everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samajammin 👍 Will definitely remove the /en/ language path. (Note though that all
static.js
pages will interpret the anchor tags into the customLink
component as well, not just when using markdown... custom component in the works will do the same):I'll fix these now to get this pulled in first.