Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds glossary contribution page [Helps with #1718] #1728

Merged
merged 1 commit into from Nov 3, 2020
Merged

Adds glossary contribution page [Helps with #1718] #1728

merged 1 commit into from Nov 3, 2020

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Nov 3, 2020

Description

  • Adds glossary to list of ways to contribute on /en/contributing/ with link to /en/conributing/adding-glossary-terms/ where a new .md file provides layout and expectations for new glossary terms
  • Link provided to GitHub, where new issue template suggest_glossary_term.md has been created and is referenced, to help organize future submissions
  • Updated bottom of glossary page with 'Sources' and 'Contribute' section headers, with link to new contribution page

Related Issue

#1718
Does not "fix" this issue, as it will be ongoing with future glossary term additions, but this aims to help clarify and streamline submission process for future contributors by giving clear guidelines, directions, and templating.

Adds 'glossary' to list of ways to contribute on `/en/contributing/` with link to `/en/conributing/adding-glossary-terms/` where a new .md file provides layout and expectations for new glossary terms. Link provided to GitHub, where new issue template `suggest_glossary_term.md` is referenced. Updated bottom of glossary page with 'Sources' and 'Contribute' section headers, with link to new conrtibution page.
@github-actions github-actions bot added needs review 👀 Review is needed for this issue or pull request content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project labels Nov 3, 2020
Copy link
Contributor

@ryancreatescopy ryancreatescopy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic idea! This looks great too. I may include a contribute banner at the top of the page (as it's unlikely a user will scroll all the way) in a future PR but this is great.

Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks for adding this.

@samajammin samajammin merged commit 5c770cc into ethereum:dev Nov 3, 2020
@wackerow wackerow deleted the w/glossary-callout branch November 4, 2020 01:04
@samajammin samajammin mentioned this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits needs review 👀 Review is needed for this issue or pull request tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants