-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds search on mobile header [#1774] #1775
Conversation
Realised, I've removed the X so you can't cancel the mobile menu easily. Need to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Love the idea to make search easier to access.
The UI functionality looks great but I don't like the overall duplication of code (having the SearchContainer & it's logic/children in both Nav/index.js & Nav/mobile.js). We should refactor this so it all lives in one place. Happy to pair on this next week / do it myself when there's time available.
For sure. I had the same thought that it should live separately in one place and we reference it from index and mobile. |
@ryancreatescopy - refactored this so that:
Please double-check the functionality is what's expected but I believe this achieves our goal. |
Awesome! This pretty much does everything I intended! Couple things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two changes will allow the Search menu to open independently of the menu (eliminating that animation glitch).
Only small issue here relates to PR #1960 which I posted recently, related to the z-index of the BottomMenu
. I overlooked that this was still in the works when I posted that... If you pull the <SearchContainer>
out of the <MenuContainer>
then a z-index on the BottomMenu
would not work to force it on top.
That being said, with two dedicated buttons in the nav bar, both for search and for the menu, it may not be worth bothering to have the bar at the bottom while searching as I had previously suggested in #1959, and just keep that exclusively in the menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the edits you suggested @ryancreatescopy @wackerow - merging in!
Description
Todo
Related Issue
#1774