Stablecoins page [WIP #1934] #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancreatescopy
added
content 🖋️
github-actions
bot
added
Status: Review Needed
translation 🌍
|
FYI converted this PR to draft. |
Can we not use that feature as it prevents being able to check deploy previews on your phone 😕 |
samajammin
reviewed
Dec 1, 2020
samajammin
reviewed
Dec 1, 2020
samajammin
reviewed
Dec 1, 2020
samajammin
reviewed
Dec 1, 2020
samajammin
reviewed
Dec 1, 2020
Co-authored-by: Sam Richards <sbrichards@gmail.com>
|
Sure!
…Sent from my iPhone
On 7 Dec 2020, at 21:18, Sam Richards ***@***.***> wrote:
@ryancreatescopy this looks a bit awkward IMO. Would you be game to just change this to a text description, e.g. "Market capitalization is the total number of tokens that exist multiplied by the value per token"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
samajammin
reviewed
Dec 7, 2020
| ) | ||
| const ALGORITHMIC = translateMessageId("page-stablecoins-algorithmic", intl) | ||
|
|
||
| // TODO confirm type & url |
There was a problem hiding this comment.
@ryancreatescopy mind spot-checking me here?
There was a problem hiding this comment.
Sure, but what am I spot-checking exactly 😬 😄
added 2 commits
December 8, 2020 09:33
ryancreatescopy
commented
Dec 8, 2020
| const ALGORITHMIC = translateMessageId("page-stablecoins-algorithmic", intl) | ||
|
|
||
| // TODO confirm type & url | ||
| const stablecoins = { |
There was a problem hiding this comment.
@samajammin where is this metadata being used?
|
Everything now looks good. Just one todo @samajammin
|
github-actions
bot
added
the
dependencies 📦
samajammin
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
@ryancreatescopy I believe this is ready to go! Let's confirm the deploy preview looks good before merging.
Merged
Closed
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New stablecoins page – feedback welcome.
Related Issue
#1934