Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translated alt tags #1948

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix translated alt tags #1948

merged 1 commit into from
Nov 30, 2020

Conversation

samajammin
Copy link
Contributor

Description

Update component to string to make alt prop valid.

Related Issue

Console.error message:

index.js:2177 Warning: Failed prop type: Invalid prop `alt` of type `object` supplied to `Image`, expected `string`.
    in Image (created by ActionCard__Image)
    in ActionCard__Image (at ActionCard.js:67)
    in div (created by ActionCard__ImageWrapper)
    in ActionCard__ImageWrapper (at ActionCard.js:66)
    in a (created by Context.Consumer)
    in Location (created by Context.Consumer)
    in Link (created by Context.Consumer)
    in Location (created by GatsbyLink)
    in GatsbyLink (created by ForwardRef)
    in ForwardRef (created by Context.Consumer)
    in Link (created by Link__InternalLink)
    in Link__InternalLink (at Link.js:140)
    in Link (created by ActionCard__Card)
    in ActionCard__Card (at ActionCard.js:65)
    in ActionCard (at what-is-ethereum.js:421)
    in div (created by what-is-ethereum__ActionCardContainer)
    in what-is-ethereum__ActionCardContainer (at what-is-ethereum.js:418)
    in div (created by SharedStyledComponents__Content)
    in SharedStyledComponents__Content (at what-is-ethereum.js:405)
    in div (created by SharedStyledComponents__Page)
    in SharedStyledComponents__Page (at what-is-ethereum.js:278)
    in WhatIsEthereumPage (created by HotExportedWhatIsEthereumPage)
    in AppContainer (created by HotExportedWhatIsEthereumPage)
    in HotExportedWhatIsEthereumPage (created by PageRenderer)
    in IntlProvider (created by PageRenderer)
    in main (created by Layout__Main)
    in Layout__Main (at Layout.js:138)
    in div (created by Layout__MainContent)
    in Layout__MainContent (at Layout.js:130)
    in div (created by Layout__MainContainer)
    in Layout__MainContainer (at Layout.js:127)
    in div (created by Layout__ContentContainer)
    in Layout__ContentContainer (at Layout.js:121)
    in ThemeProvider (at Layout.js:119)
    in IntlProvider (at Layout.js:113)
    in Layout (at gatsby-browser.js:20)
    in PageRenderer (at query-result-store.js:86)
    in PageQueryStore (at root.js:56)
    in RouteHandler (at root.js:78)
    in div (created by FocusHandlerImpl)
    in FocusHandlerImpl (created by Context.Consumer)
    in FocusHandler (created by RouterImpl)
    in RouterImpl (created by Context.Consumer)
    in Location (created by Context.Consumer)
    in Router (at root.js:73)
    in ScrollHandler (at root.js:69)
    in RouteUpdates (at root.js:68)
    in EnsureResources (at root.js:66)
    in LocationHandler (at root.js:124)
    in LocationProvider (created by Context.Consumer)
    in Location (at root.js:123)
    in Root (at root.js:131)
    in MDXProvider (at wrap-root-element.js:65)
    in MDXScopeProvider (at wrap-root-element.js:64)
    in Unknown
    in Unknown (at wrap-root-element.js:72)
    in StaticQueryStore (at root.js:138)
    in _default (at app.js:103)

@github-actions github-actions bot added Status: Review Needed content 🖋️ This involves copy additions or edits labels Nov 25, 2020
@samajammin
Copy link
Contributor Author

FYI @ph5500 something to be aware of - looks like passing the <Translation/> component as an image alt tag is invalid.

@samajammin samajammin merged commit 689d9d6 into dev Nov 30, 2020
@samajammin samajammin deleted the fix-image-alt branch November 30, 2020 22:13
@samajammin samajammin mentioned this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants