Phil/set up eth2 translations 2 #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Review Needed
translation 🌍
samajammin
requested changes
Nov 25, 2020
| @@ -93,29 +98,48 @@ const Eth2BeaconChainActions = ({ data }) => { | |||
| <StyledCardContainer> | |||
| <StyledCardLeft | |||
| emoji=":money_with_wings:" | |||
| title="Become a staker" | |||
| description="Staking is live! If you want to stake your ETH to help secure the network, make sure you’re aware of the risks." | |||
| title={intl.formatMessage({ | |||
There was a problem hiding this comment.
For these uses of intl.formatMessage let's refactor to use our new utility function translateMessageId :
https://github.com/ethereum/ethereum-org-website/blob/dev/src/utils/translations.js#L56
Moving forward this will save us from the repetition of adding a defaultMessage.
More context on the reasoning here: #1940
samajammin
reviewed
Nov 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up Eth2 components for translations. [Fixes #1937]
Description
Set up translations using gatsby-plugin-intl for the following pages:
Related Issue