Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed from isn't to is as that makes more sense. #1989

Merged
merged 2 commits into from
Nov 30, 2020
Merged

changed from isn't to is as that makes more sense. #1989

merged 2 commits into from
Nov 30, 2020

Conversation

tentodev
Copy link
Contributor

I was reading through the Ethereum documentation and came across this sentence and felt that this is a mistake. I am not a blockchain expert so if I am wrong, an explanation would be appreciated.

Description

Related Issue

I was reading through the Ethereum documentation and came across this sentence and felt that this is a mistake. I am not a blockchain expert so if I am wrong, an explanation would be appreciated.
@github-actions github-actions bot added Status: Review Needed content 🖋️ This involves copy additions or edits labels Nov 30, 2020
@ryancreatescopy
Copy link
Contributor

Hi @tentodev isn't is actually correct. I've updated your PR to try and make it clearer that if Validator X isn't chosen to propose a new block, they must attest to validator Y's proposal.

@sudo-vaibhav
Copy link
Contributor

this makes a lot more sense.

@ryancreatescopy
Copy link
Contributor

@all-contributors please add @tentodev for content and bugs.

@allcontributors
Copy link
Contributor

@ryancreatescopy

I've put up a pull request to add @tentodev! 🎉

@ryancreatescopy ryancreatescopy merged commit ea0e45b into ethereum:dev Nov 30, 2020
@samajammin samajammin mentioned this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants