Sanitizes tutorial tags before grouping [Fixes #2020] #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styling to uppercase handled with CSS
github-actions
bot
added
the
needs review 👀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces
allTagsdown to array of unique tags after sanitizing them with.toLowerCase().trim(). This array is then sorted by name, since the previously capitalized tags are at the top from the returned query data.Now for example: If you list "JavaScript " when making a new tutorial markdown, it will lump with "javascript", sum up the totals for each, and display "JAVASCRIPT" with the proper sum on the UI. Clicking this will properly filter for all of them, as all tags are forced to lowercase and trimmed before being stored in the
allTutorialsconstant.Kept styling logic separate, leaving the CSS to style these as uppercase.
Related Issue #2020