Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added transparent logo. #2051

Merged
merged 13 commits into from
Dec 4, 2020
Merged

Added transparent logo. #2051

merged 13 commits into from
Dec 4, 2020

Conversation

guidoguy22
Copy link
Contributor

I edited the logo used in the readme.md file and removed transparency, so it doesn't look bad in dark theme.
I also edited the global font size to 62.5%:

1rem (root font size) = 16px (but may vary)
1rem = 62.5% => 1rem = 10px (10px is easier to use than 16px)
And then I reverted it back in body {}, font-size: 1.6rem.

This means, that now anyone can use 1rem as 10px, but the font size stays the same.
Everything defined by rem in the css will be more responsible, even though I don't see lots of it there now.

Description

Added eth-transparent.png
Changed eth.png to eth-transparent.png in the readme.md file
Added some CSS for custom scrollbar into the layout file.
It looks more modern now 馃憤

Related Issue

image
image

Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OliverPetrovic - thanks for this contribution!

The README image update looks great.

Re: the CSS changes around font sizes, the current updates won't work as-is. Check out the preview deploy: https://deploy-preview-2051--ethereumorg.netlify.app/en/

e.g. the site nav text is now enormous:
Image 2020-12-04 at 10 50 46 AM

While I'm not opposed to this base change, I'm not convinced by it. I can see the developer experience benefit to be able to think of rems in factors of 10px but in reality this would require us to update large amounts of CSS (doing a grep search in our codebase for rem;, there's over 1K results). There's also the fact that we tend to style layouts in multiples of 8px (something we should document more in our design system 馃槄), so working with rem as a factor of 16px hasn't really been an issue.

Let me know your thoughts on this. If we want to roll out a refactor of all our rem CSS use, I suggest we move that to a separate PR so we can merge the image change.

Thanks again for taking the time!

@guidoguy22
Copy link
Contributor Author

Hello,
thank you for letting me know.
I removed the rem stuff, so it should be just the image right now.

Thank you!

Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@samajammin samajammin merged commit a77bb0f into ethereum:dev Dec 4, 2020
@samajammin
Copy link
Contributor

@all-contributors please add @OliverPetrovic for content.

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @OliverPetrovic! 馃帀

@samajammin
Copy link
Contributor

@OliverPetrovic out of curiosity, what do you use to view Github in dark mode? 馃寶

@guidoguy22
Copy link
Contributor Author

Hello,
I use this chrome extension:

https://chrome.google.com/webstore/detail/github-dark-theme/odkdlljoangmamjilkamahebpkgpeacp

Thanks :)
~ Oliver

@samajammin samajammin mentioned this pull request Dec 8, 2020
@wackerow
Copy link
Member

wackerow commented Dec 9, 2020

Love the timing of this... GitHub just officially released Dark Mode haha.... I was using "Dark Reader" extension, but this is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 馃摉 Change or add documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants