-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added transparent logo. #2051
Added transparent logo. #2051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @OliverPetrovic - thanks for this contribution!
The README image update looks great.
Re: the CSS changes around font sizes, the current updates won't work as-is. Check out the preview deploy: https://deploy-preview-2051--ethereumorg.netlify.app/en/
e.g. the site nav text is now enormous:
While I'm not opposed to this base change, I'm not convinced by it. I can see the developer experience benefit to be able to think of rems in factors of 10px but in reality this would require us to update large amounts of CSS (doing a grep search in our codebase for rem;
, there's over 1K results). There's also the fact that we tend to style layouts in multiples of 8px (something we should document more in our design system 馃槄), so working with rem
as a factor of 16px hasn't really been an issue.
Let me know your thoughts on this. If we want to roll out a refactor of all our rem
CSS use, I suggest we move that to a separate PR so we can merge the image change.
Thanks again for taking the time!
Hello, Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
@all-contributors please add @OliverPetrovic for content. |
I've put up a pull request to add @OliverPetrovic! 馃帀 |
@OliverPetrovic out of curiosity, what do you use to view Github in dark mode? 馃寶 |
Hello, https://chrome.google.com/webstore/detail/github-dark-theme/odkdlljoangmamjilkamahebpkgpeacp Thanks :) |
Love the timing of this... GitHub just officially released Dark Mode haha.... I was using "Dark Reader" extension, but this is better |
I edited the logo used in the readme.md file and removed transparency, so it doesn't look bad in dark theme.
I also edited the global font size to 62.5%:
1rem (root font size) = 16px (but may vary)
1rem = 62.5% => 1rem = 10px (10px is easier to use than 16px)
And then I reverted it back in body {}, font-size: 1.6rem.
This means, that now anyone can use 1rem as 10px, but the font size stays the same.
Everything defined by rem in the css will be more responsible, even though I don't see lots of it there now.
Description
Added eth-transparent.png
Changed eth.png to eth-transparent.png in the readme.md file
Added some CSS for custom scrollbar into the layout file.
It looks more modern now 馃憤
Related Issue