-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codeblock refactor w/ hide/show [Fixes #1776] #2066
Conversation
reverted Icon.js changes
placed this value into its own constant to help with redundancy. removed unused import. eliminates large padding-top if no 'copy' nor 'hide/show' buttons being displayed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Paul, my only comment is on the button size. I understand why you've made the text smaller but I think this could be at the detriment of accessibility – it's pretty hard to read. I think it'd be ok with the button copy at 16px as per the others.
@ryancreatescopy That padding look okay to you? Let me know if you have any other design suggestions, happy to tweak as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge!
Description
Refactors codeblocks, automatically collapsing code blocks over 8 lines, with button to
show all
/show less
, and refactored Copy button to address color dissonance and to match new changes.show all
/show less
button toggles between collapsed with overflow scrolling, and showing all lines of codepadding-top
adjusted IF buttons present, to avoid overlapping for smaller devices or long strings on line 1 of code, leaving simple codeblocks without copy functionality grossly unchangedTODO
comment)(On that note, went through the markdown files and removed any blank lines that were placed before closing ``` tag, which were adding an additional empty line at the end of codeblocks when rendered)
Related Issue #1776
(*autoformatting added a
\
before $USD on oracles page... two commits trying to fix it just keeps autoformatting it back in)