Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation styling adjustments #2172

Merged
merged 3 commits into from Jan 6, 2021
Merged

Translation styling adjustments #2172

merged 3 commits into from Jan 6, 2021

Conversation

wackerow
Copy link
Member

Description

  • Changed couple instances of translation text that was pre-styled as all-caps. Moved styling for all caps to css using text-transform: uppercase;
  • Cleaned up some stray extra spaces in some translation phrases that were not being rendered. Many of these were at the beginning of paragraphs... if the goal here was to indent the text, let me know, as we should use styling for that as well, since these leading spaces in the JSON string values do not render.
  • Also, while eyeing spaces, added a space to two instances of "32ETH" to make it "32 ETH" for consistency as this is what is used elsewhere on the site.

Related Issue

(None filed, per conversation in #2047)

Leading spaces from JSON not rendered, thus removed. Also corrects a few double-spaces
@github-actions github-actions bot added needs review 👀 Review is needed for this issue or pull request content 🖋️ This involves copy additions or edits labels Dec 24, 2020
Copy link
Contributor

@ryancreatescopy ryancreatescopy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks!

@samajammin samajammin merged commit d02d52b into ethereum:dev Jan 6, 2021
@samajammin samajammin mentioned this pull request Jan 6, 2021
@wackerow wackerow deleted the w/en branch January 6, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits needs review 👀 Review is needed for this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants