Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Potugueseh translation [Resolves #221] #279

Closed
wants to merge 1 commit into from

Conversation

rodgeraraujo
Copy link

Description

Add Portuguese translation at ethereum.org/br

Related Issue

#221

Screenshots (if appropriate):

Checklist:

  • I have read the contributing guidelines in the project README.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thanks for proactively making this contribution!

I made a few comments & I've sent this over to our translation team for review. In the meantime, in order to complete this base translation, we'll also want to translate the "beginners" page & the "developers" page:
https://github.com/ethereum/ethereum-org-website/blob/dev/docs/beginners/index.md
https://github.com/ethereum/ethereum-org-website/blob/dev/docs/developers/index.md

Please let me know if you're able to translate those 2 additional pages. If not, I'll leave this PR open for now & we can work to find additional folks to help out.

Thanks again! It's volunteers like you that make this translation effort possible 😄

title: Aprenda sobre Ethereum
meta:
- name: description
content: A set of technical and non-technical articles, guides, and resources to learn about Ethereum.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These descriptions aren't necessary but if we include them we should translate them.

- property: og:title
content: Aprenda sobre Ethereum
- property: og:description
content: A set of technical and non-technical articles, guides, and resources to learn about Ethereum.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.


## Proof of Work and Mining

Ethereum currently uses a system called “Proof of Work”. This allows the Ethereum network to agree on the state of all information recorded on the Ethereum blockchain, and prevents certain kinds of economic attacks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be translated.

layout: home
---

<HomePage/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to complete this homepage translation, we'll need to add the text & links in the translations.js file. See the existing sections as examples: https://github.com/ethereum/ethereum-org-website/blob/dev/docs/.vuepress/theme/utils/translations.js#L5

@rodgeraraujo
Copy link
Author

@samajammin Ok! Later I complete the translations, and correct the remaining errors!

@samajammin
Copy link
Contributor

Hey @rodgeraraujo - I'm sorry for the inconvenience but would you mind adding this translation to our CrowdIn project? This makes it easiest for our translation team to process. Here's an invite to get started:
https://crowdin.com/project/ethereumfoundation/invite

Here's the project:
https://crowdin.com/project/ethereumfoundation/sv-SE#

Once that's complete, I can fix these build errors & get this deployed. Feel free to post any questions you have here. I can connect you with the lead of our Translation Program to ensure you have everything you need.

Looking forward to getting your Portuguese translations up on the website!

@natacha-involves
Copy link

Hi, do you guys need help with this? I can help translate to Portuguese :)

@samajammin
Copy link
Contributor

Thanks @natacha-involves! The more the merrier :)

Please see the CrowdIn invite above & let us know if you have any questions. It'd be great if you could help get @rodgeraraujo 's work into the Crowdin project.

@samajammin
Copy link
Contributor

@rodgeraraujo @natacha-involves - apologies, looks like I shared the wrong link above. We actually have 2 separate Portuguese translations:
https://crowdin.com/project/ethereumfoundation/pt-PT#
https://crowdin.com/project/ethereumfoundation/pt-BR#
Please contribute to whichever translation you're more comfortable with. Thanks again!

@samajammin samajammin added the translation 🌍 This is related to our Translation Program label Oct 23, 2019
@samajammin
Copy link
Contributor

@rodgeraraujo if you don't mind granting me access to your fork of this repo, I can work to fix the failing build & complete this PR. Please let me know.

@samajammin
Copy link
Contributor

samajammin commented Nov 6, 2019

@rodgeraraujo @natacha-involves could you please clarify which Portuguese this is? Brazilian?

It looks like that is now 100% in CrowdIn (🎉 ):
https://crowdin.com/project/ethereumfoundation/pt-BR#

The other Portuguese is at 60%:
https://crowdin.com/project/ethereumfoundation/pt-PT#

Given that this PR only translates 3 of the 5 files, I'm leaning towards closing this out in favor of a new PR from the CrowdIn source files. Let me know if you'd like to take a swing at it! Issue #358 provides the step by step of what's necessary. Otherwise I can hop on this soon.

@samajammin
Copy link
Contributor

@all-contributors please add @rodgeraraujo for translation

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @rodgeraraujo! 🎉

@samajammin
Copy link
Contributor

@all-contributors please add @natacha-involves for translation

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @natacha-involves! 🎉

@samajammin
Copy link
Contributor

Haven't heard from you in 20 days now, so closing this out for maintenance. Feel free to re-open & complete it! We've created a bounty for this work, which you can see here: #543

@samajammin samajammin closed this Nov 20, 2019
@samajammin
Copy link
Contributor

Thank you again for the contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants