Update index.md #3444
Merged
Update index.md #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited for punctuation and a broken link.
jbgwu
requested review from
corwintines,
GeorgeTrotter,
jjmstark,
pettinarip,
samajammin and
wackerow
as code owners
github-actions
bot
added
Status: Review Needed
content 🖋️
wackerow
requested changes
Jul 30, 2021
| In this article we will analyze [Ryuya Nakamura's ERC-721 contract](https://github.com/vyperlang/vyper/blob/master/examples/tokens/ERC721.vy). | ||
| In this article we will analyze [Ryuya Nakamura's ERC-721 contract](https://github.com/vyperlang/vyper/blob/master/vyper/builtin_interfaces/ERC721.py). |
There was a problem hiding this comment.
Little confused, the original link is working for me and appears to be the contract being referenced. Could we revert this? Or am I missing something?
|
Hey @jbgwu ✌️ Thanks for the PR. Agree with Paul that the original reference to the vyper file was the correct one so I've reverted that (feel free to comment if you think we've made a mistake). Appreciate the improvements you've made. Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And remember to claim your POAP also 🥳!. |
|
@all-contributors please add @jbgwu for docs |
|
I've put up a pull request to add @jbgwu! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited for punctuation and a broken link.
Description
Related Issue