Gatsby v4 upgrade [Fixes #4271] #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrades gatsby-plugin-sharp and gatsby-transformer-sharp
Removes PRESERVE_WEBPACK_CACHE from gatsby config per Gatsby logs: ("Those flags no longer have any effect and you can remove them from config")
github-actions
bot
added
content 🖋️
jley81
approved these changes
Oct 27, 2021
jley81
approved these changes
Oct 27, 2021
gatsby@4.0.2, gatsby-plugin-sharp@4.0.1, react-instantsearch-dom@6.15.0
|
@wackerow I've changed the config for I've used the default configs from the plugin. This means that the
Things to consider:
options: {
output: `/`, // the default value is `/sitemap`
...
}
|
github-actions
bot
added
the
translation 🌍
This reverts commit cf830aa.
These parameters are ignored on Gatsby images marked as FULL_WIDTH, causing console warnings when left in.
This catch is not really an "error", as it is expected to occur on certain files and can default to returning true. Removing should help tech debt by reducing number of unhelpful errors/warnings in build log.
wackerow
requested review from
corwintines,
minimalsm,
pettinarip and
samajammin
as code owners
Fixes: The requested width "100px" for a resolutions field for the file /usr/src/app/www/src/assets/dev-tools/nftschool.png was larger than the actual image width of 90px! If possible, replace the current image with a larger one.
samajammin
reviewed
Dec 7, 2021
samajammin
reviewed
Dec 7, 2021
| @@ -76,7 +80,6 @@ const checkIsMdxOutdated = (path) => { | |||
| intlMatch += match.replace(re, (_, p1, p2) => p1 + p2) | |||
| }) | |||
| } catch { | |||
| console.error("regex error") | |||
There was a problem hiding this comment.
I believe we still want this error log.
There was a problem hiding this comment.
Took this out after it was just producing a handful of non-specific errors in the build console. Will replace it with
console.error(`regex error in ${englishPath}`)
There was a problem hiding this comment.
After chatting with @pettinarip decided to change this to a console.warn instead
samajammin
reviewed
Dec 7, 2021
src/content/developers/tutorials/uniswap-v2-annotated-code/index.md
Outdated
Show resolved
Hide resolved
samajammin
reviewed
Dec 7, 2021
src/content/developers/tutorials/uniswap-v2-annotated-code/index.md
Outdated
Show resolved
Hide resolved
removes `cp` command from onPostBuild
This reverts commit 8f21dc5.
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby-plugin-image)gatsby-plugin-imagepublic/functionsfor compatibility between Gatsby Cloud builds and Netlify servingdevbranch (includingdev)devintomaster, which will build final production build frommasterbranch.masterbranch using existing Netlify account.ethereum.orgRelated Issue
#4271