Summary points refactor for eth2 template
#4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
corwintines,
minimalsm,
pettinarip and
samajammin
as code owners
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 4m PerformanceLighthouse report
|
Gatsby Cloud Build Reportethereum-org-website-dev2 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 5m PerformanceLighthouse report
|
minimalsm
approved these changes
Dec 16, 2021
This was referenced Dec 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
summaryPoints(array of strings), with four individual frontmatter properties, each a simple string without quotes wrapping.eth2pages (beacon-chain,merge, andshard-chains)template/eth2.jsto use these instead, creating thesummaryPointsarray here instead.Related Issue
When importing markdown files from Crowdin, we've been encountering recurrent issues where the
summaryPointsarray is being turned into a string. Using different quotation marks (to accommodate for quotes used within the string) were causing complications.See notion with notes/issues from recent import:
https://www.notion.so/efdn/12-11-2021-Crowdin-Import-Notes-e7fccce737164ac6bb8ea7659fb95ebf
This should simplify Crowdin imports in the future, preventing the recurrent bugs being caused by this array.