Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth price granularity #4797

Merged
merged 2 commits into from Dec 19, 2021
Merged

Update eth price granularity #4797

merged 2 commits into from Dec 19, 2021

Conversation

MiConnell
Copy link
Contributor

Description

This PR updates the granularity of the ether price chart to daily so it visually matches the other charts on the stats box grid.

Examples below (both 90 day)

current site:
current-site

proposed update:
updated-chart

this will make the full grid look more uniform, instead of the price being less smooth than the other metrics:

full-view

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-) thanks for the PR @MiConnell

@corwintines
Copy link
Member

@all-contributors can you add @MiConnell for code

@allcontributors
Copy link
Contributor

@corwintines

I've put up a pull request to add @MiConnell! 🎉

@corwintines corwintines merged commit 601c197 into ethereum:dev Dec 19, 2021
@MiConnell MiConnell deleted the update-eth-price-granularity branch December 19, 2021 18:30
@wackerow wackerow mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants