Remove HTML from json files #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimalsm
requested review from
corwintines,
pettinarip,
samajammin and
wackerow
as code owners
wackerow
approved these changes
Dec 16, 2021
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 6m PerformanceLighthouse report
|
|
@minimalsm @wackerow if we're not going to use HTML in these translation strings, should we revert the Translation component? https://github.com/ethereum/ethereum-org-website/blob/dev/src/components/Translation.js#L2 |
|
I've not removed every instance of this as per your comments yesterday about trying to support HTML formatting on CrowdIn. This PR removed it from the tutorial/wallet instances. However, we still use it on the eth2 bug-bounty page. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary HTML strong tags from JSON files
Related Issue
#4625