Show total translator amount on contributors page #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corwintines
requested review from
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
minimalsm
reviewed
Dec 20, 2021
| @@ -5,5 +5,6 @@ | |||
| "page-contributing-translation-program-contributors-our-translators-2": "With thousands of community members contributing translations to our project, it is difficult to acknowledge everyone.", | |||
| "page-contributing-translation-program-contributors-our-translators-3": "All translators are listed alphabetically based on their chosen name in Crowdin. If you are a translator and would like to use your real name, nickname, ENS domain, etc., you can change your Full Name in Crowdin.", | |||
| "page-contributing-translation-program-contributors-meta-title": "Our Translations", | |||
| "page-contributing-translation-program-contributors-meta-description": "A list of our translation contributors." | |||
| "page-contributing-translation-program-contributors-meta-description": "A list of our translation contributors.", | |||
| "page-contributing-translation-program-contributors-total-contributors": "people have contributed to ethereum.org to date!" | |||
There was a problem hiding this comment.
I think doing the translation this way might cause grammar problems in other languages? @lukassim
minimalsm
reviewed
Dec 20, 2021
Comment on lines
74
to
75
| {translatorData.length}{" "} | ||
| <Translation id="page-contributing-translation-program-contributors-total-contributors" /> |
There was a problem hiding this comment.
maybe something like 'Number of contributors: 2500'
wackerow
approved these changes
Dec 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show total number of contributors on /contrubting/translation-program/contributors page