Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Simplified: Learn Pages #4870

Merged
merged 4 commits into from
Dec 22, 2021
Merged

Chinese Simplified: Learn Pages #4870

merged 4 commits into from
Dec 22, 2021

Conversation

wackerow
Copy link
Member

Description

Updates Chinese Simplified (zh) "Learn Pages" content with latest from Crowdin

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Dec 21, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 21, 2021

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 5m

Performance

Lighthouse report

Metric Score
Performance 🔶 22
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

src/content/translations/zh/about/index.md Outdated Show resolved Hide resolved
src/content/translations/zh/about/index.md Outdated Show resolved Hide resolved
src/content/translations/zh/about/index.md Outdated Show resolved Hide resolved
src/content/translations/zh/about/index.md Outdated Show resolved Hide resolved
src/content/translations/zh/enterprise/index.md Outdated Show resolved Hide resolved
src/content/translations/zh/history/index.md Outdated Show resolved Hide resolved
src/content/translations/zh/glossary/index.md Outdated Show resolved Hide resolved
src/content/translations/zh/glossary/index.md Outdated Show resolved Hide resolved
- [请阅读以太坊基金会公告](https://blog.ethereum.org/2021/07/15/london-mainnet-announcement/)
- [请阅读以太坊 Cat Herder 的解释](https://medium.com/ethereum-cat-herders/london-upgrade-overview-8eccb0041b41)

<ExpandableCard title="伦敦 EIP" contentPreview="Official improvements included in this upgrade.">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not translating this ^

@@ -27,11 +82,11 @@ isOutdated: true

### 信标链的起源 {#beacon-chain-genesis}

<Emoji text=":calendar:" size={1} mr={"0.5rem"} mb={"0.5rem"} /> <code>Dec-01-2020 12:00:35 PM +UTC</code><br /> <Emoji text=":bricks:" size={1} mr={"0.5rem"} mb={"0.5rem"} /> 信标链区块高度:<a href="https://beaconscan.com/slot/1">1</a><br /> <Emoji text=":money_bag:" size={1} mr={"0.5rem"} mb={"0.5rem"} /> ETH 价格:$586.23 USD<br /> <Emoji text=":desktop_computer:" size={1} mr={"0.5rem"} mb={"0.5rem"} /> <a href="https://web.archive.org/web/20201207184633/https://www.ethereum.org/cn/">ethereum.org</a>
<emoji text=":calendar:" size={1} mr={"0.5rem"} mb={"0.5rem"} /> <code>Dec-01-2020 12:00:35 PM +UTC</code><br /> <Emoji text=":bricks:" size={1} mr={"0.5rem"} mb={"0.5rem"} /> 信标链区块号:<a href="https://beaconscan.com/slot/1">1</a><br /> <Emoji text=":money_bag:" size={1} mr={"0.5rem"} mb={"0.5rem"} /> ETH 价格:586.23 美元<br /> <Emoji text=":desktop_computer:" size={1} mr={"0.5rem"} mb={"0.5rem"} /> <a href="https://web.archive.org/web/20201207184633/https://www.ethereum.org/cn/">ethereum.org</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this lowercase Emojis will break the component

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing, committed to force a re-deploy.

Seems like some of these pages have been cached and aren't showing the updated version on the deploy. e.g. see old history page below

Screenshot 2021-12-22 at 16 23 23

Screenshot 2021-12-22 at 16 25 04

@minimalsm
Copy link
Contributor

This should be good to go if the Emojis on the history page render properly next build

@minimalsm minimalsm merged commit 8b6c466 into dev Dec 22, 2021
@minimalsm minimalsm deleted the zh-learn-pages branch December 22, 2021 18:42
@wackerow wackerow mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants