Including in the documentation how the swap fee is enforced in Uniswap V2 #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astutejoe
requested review from
corwintines,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 6m PerformanceLighthouse report
|
minimalsm
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Thanks for spotting and fixing this @astutejoe ✌️.
Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And remember to claim your POAP also 🥳! We're currently working on our 2022 POAPs and they'll be released soon.
|
@all-contributors please add @astutejoe for docs |
|
I've put up a pull request to add @astutejoe! 🎉 |
|
Hey, that's very nice of you @minimalsm !! I appreciate it! I didn't know about the POAPs, that's great too! I'll make sure to find more places where I can meaningfully contribute :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the documentation only highlights how we can quote a token amount while accounting for the swap fees, we also mention how the protocol earns fees but it was never explained how the liquidity pool earns exchange fees, understandably so as the code for that is rather convoluted, which is also why it's especially important that it's mentioned in this breakdown.
English is not my native language and this is rather a complex topic/calculation so I'd be happy to include any suggested changes.
Related issue: #5186