Add new upcoming events [Fixes #5221] #5245
Conversation
vluna
requested review from
corwintines,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
github-actions
bot
added
the
needs review 👀
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 11m PerformanceLighthouse report
|
There was a problem hiding this comment.
Nice! Thanks @vluna.
A few thoughts:
If we don't have a description, we should write a simple one.
e.g. ETHWarsaw is a hackathon in Warsaw, Poland, expected in Q4 2022.
I don't think we should link out to dead meetup.com meetings. Do they have an alternative? E.g. Twitter or if they are part of ETHGlobal we could just link there?
If something is TBD, we don't currently have a good way to show this and spanning the event across the whole quarter is confusing to users.
- We could remove ETHWarsaw, ETHKyiv, Liscon, EthLisbon, ETHBogota, DevCon until they get official dates IMO.
- We could refactor the component to better support this.
Less of a priority but this list is super long now. I think we should paginate or add 'load more' functionality to reduce cognitive load here.
| "endDate": "2022-06-30" | ||
| }, | ||
| { | ||
| "title": "ETH SF", |
There was a problem hiding this comment.
Are there two events in SF?
There was a problem hiding this comment.
Yup, it seems like it.
minimalsm
added
changes requested
github-actions
bot
added
the
needs review 👀
|
@minimalsm Applied your suggestions. Let me know what you think. |
There was a problem hiding this comment.
Aw yeah, great to see all these events getting listed. Thanks @vluna!
@minimalsm I think using isSecondary on that button would be more fitting, but we can debate that separately... gonna bring this in
title > sentence case
|
Build is showing as failed because it ran out of memory: I cleared cache and rebuilt it and it worked fine, just doesn't seem to be updating here. |
Description
Related Issue
#5221