Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize load of translation reports #5933

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

pettinarip
Copy link
Member

Currently, the whole translation JSON reports used in /contributing/translation-program/acknowledgements/ are being bundled in the final js files.

Description

This PR changes that, loading the files in the Gatbsy data layer in order to use graphql to pull only the necessary data.

@github-actions github-actions bot added dependencies 📦 Changes related to project dependencies internal 🏠 labels Apr 7, 2022
@minimalsm
Copy link
Contributor

@pettinarip, the build for this is timing out after 2 hours. Could you have a look 🙏

@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 11, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 9m

Performance

Lighthouse report

Metric Score
Performance 🔶 25
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 85

🔗 View full report

@pettinarip
Copy link
Member Author

@minimalsm not sure what happened there. The IMAGE_PROCESSING job stuck. I triggered the build again and it went well 🤷🏼

@minimalsm minimalsm merged commit 775f26f into dev Apr 14, 2022
@minimalsm minimalsm deleted the translation-reports-json branch April 14, 2022 16:16
@wackerow wackerow mentioned this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 Changes related to project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants