Staking epic patches #6035
Merged
Staking epic patches #6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce precision and add approximation indicator
wackerow
requested review from
samajammin,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 12m PerformanceLighthouse report
|
minimalsm
reviewed
Apr 14, 2022
minimalsm
reviewed
Apr 14, 2022
| @@ -96,7 +96,7 @@ const StatsBoxGrid = () => { | |||
| const valueCurrentApr = formatPercentage(currentAprDecimal) | |||
| setTotalEth(valueTotalEth) | |||
| setTotalValidators(valueTotalValidators) | |||
| setCurrentApr(valueCurrentApr) | |||
| setCurrentApr(`~${valueCurrentApr}`) | |||
There was a problem hiding this comment.
Not a huge deal until we migrate to TypeScript, but we're doing an implicit type conversion from int to string here
There was a problem hiding this comment.
The formatPercentage helper function returns a string already before this is passed to the state setter. This doesn't actually add any implicit conversion, but yeah... TS will soon help make all of this more clear.
minimalsm
approved these changes
Apr 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few initial bugs noted on recently merged staking epic PR.
Preview: https://ethereumorgwebsitedev01-stakingpatches.gtsb.io/en/staking