Filter out stablecoins not on Ethereum #6300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corwintines
requested review from
samajammin,
wackerow,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 9m PerformanceLighthouse report
|
wackerow
approved these changes
May 11, 2022
samajammin
reviewed
May 12, 2022
src/pages/stablecoins.js
Outdated
| "https://api.coingecko.com/api/v3/coins/markets?vs_currency=usd&category=stablecoins&order=market_cap_desc&per_page=100&page=1&sparkline=false" | ||
| ) | ||
|
|
||
| const filteredData = stablecoinData.filter( |
There was a problem hiding this comment.
Perhaps we should add a comment to make clear what's happening here? Or perhaps a different variable name instead of filteredData to clarify, e.g. ethereumStablecoinData?
There was a problem hiding this comment.
Will give another pass on variable names, and some documentation. Guilty of not writing enough of that.
samajammin
reviewed
May 12, 2022
|
@samajammin @minimalsm addressed the comments :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description