Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types of standards #7322

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Update types of standards #7322

merged 3 commits into from
Aug 8, 2022

Conversation

rogueassasin1729
Copy link
Contributor

Updated the Types of Standard tab to elucidate the different types of EIPs(Standard, Meta & Informational) , and list down the sub-categories of Standard Track EIP.

Description

Related Issue

Updated the Types of Standard tab to elucidate the different types of EIPs(Standard, Meta & Informational) , and list down the sub-categories of Standard Track EIP.
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 6, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 29m

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-) Thanks for the PR @rogueassasin1729

I've asked for a double-check of this in the cat herders Discord but we'll get it merged in soon.

src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/standards/index.md Outdated Show resolved Hide resolved
minimalsm and others added 2 commits August 8, 2022 18:39
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@minimalsm
Copy link
Contributor

Thanks @rogueassasin1729 and @Pandapip1 <3

Both please remember to claim yours also 🥳!

@minimalsm
Copy link
Contributor

@all-contributors please add @rogueassasin1729 for docs

@allcontributors
Copy link
Contributor

@minimalsm

I've put up a pull request to add @rogueassasin1729! 🎉

@minimalsm
Copy link
Contributor

@all-contributors please add @Pandapip1 for docs

@allcontributors
Copy link
Contributor

@minimalsm

I've put up a pull request to add @Pandapip1! 🎉

@minimalsm minimalsm merged commit 20b7fb8 into ethereum:dev Aug 8, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Aug 8, 2022

Woohoo, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ethereum.org Contributor:
GitPOAP: 2022 Ethereum.org Contributor GitPOAP Badge

Head on over to GitPOAP.io and connect your GitHub account to mint!


- [List of ERCs](https://eips.ethereum.org/erc)
- [Standards Track](https://eips.ethereum.org/): describes any change that affects most or all Ethereum implementations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rather call it "EIPs website".
IMHO, Pointing "Standard Track" to https://eips.ethereum.org/ may not be appropriate.

Copy link
Member

@Pandapip1 Pandapip1 Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that's definitely a typo. Fixing.

EDIT: Wait, duh, we don't have a page for standards track EIPs.


- [List of ERCs](https://eips.ethereum.org/erc)
- [Standards Track](https://eips.ethereum.org/): describes any change that affects most or all Ethereum implementations
- [Meta Track](https://eips.ethereum.org/meta): describes a process surrounding Ethereum or proposes a change to a process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Meta Track" isn't commonly used. Probably "Meta EIPs" will be a better fit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the technical term and is the correct term to use here.

- [List of ERCs](https://eips.ethereum.org/erc)
- [Standards Track](https://eips.ethereum.org/): describes any change that affects most or all Ethereum implementations
- [Meta Track](https://eips.ethereum.org/meta): describes a process surrounding Ethereum or proposes a change to a process
- [Informational Track](https://eips.ethereum.org/informational): describes an Ethereum design issue or provides general guidelines or information to the Ethereum community
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comment above. IMO, "Informational EIPs" will be better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, this is the correct term to use here.

@minimalsm minimalsm mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants