Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a wallet table: fade icons in and out when dropdown select is changed #7371

Merged
merged 6 commits into from Oct 4, 2022

Conversation

corwintines
Copy link
Member

Description

  • Adds functionality in for fading out and in the feature icons for a wallet in the WalletTable component.

@github-actions github-actions bot added the needs review 👀 Review is needed for this issue or pull request label Aug 9, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 9, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 12m

@corwintines
Copy link
Member Author

Open to changing the timing of this animation. Some user feedback from user testing suggested that the compare features didn't seem like they were doing anything because the icons weren't updating (they were, just didn't look like it since they didn't change). This adds a fade-in and out animation to give the appearance of things changing, even if it's just going from true for one feature to true for another.

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

Agree on changing the timing... it feels a little too dramatic as is 😅.

Also left a comment about us picking an animation convention and but not necessarily a blocker to this PR.

import { getImage, GatsbyImage } from "gatsby-plugin-image"
import { keyframes } from "@emotion/react"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we decide on a convention of how we animate (maybe framer-motion?) on ethereum.org?

We now have at least three ways to animate:

  • motion components
  • CSS animations
  • keyframes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I know that we use framer for a lot of other animations so will refactor to that.

src/components/FindWallet/WalletTable.tsx Outdated Show resolved Hide resolved
corwintines and others added 2 commits August 10, 2022 11:55
Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Aug 18, 2022
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nloureiro or @konopkja to review?

@minimalsm minimalsm added ui design 💅 This issue needs UI design ux design 🔬 This issue needs UX design and removed content 🖋️ This involves copy additions or edits labels Oct 4, 2022
@minimalsm minimalsm changed the title fade icons in and out when dropdown is changed Find a wallet table: fade icons in and out when dropdown select is changed Oct 4, 2022
@konopkja
Copy link
Contributor

konopkja commented Oct 4, 2022

looks good to me

@minimalsm minimalsm merged commit 0d89b79 into dev Oct 4, 2022
@minimalsm minimalsm deleted the fade-icons-find-wallet branch October 4, 2022 10:17
@nloureiro
Copy link
Contributor

LGTM.

@nloureiro or @konopkja to review?

Just to be sure, are we working on this fading?

fading.icons.mov

If yes, it looks good!

@minimalsm
Copy link
Contributor

@nloureiro yes :-)! thanks guys, merged!

@corwintines corwintines mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👀 Review is needed for this issue or pull request ui design 💅 This issue needs UI design ux design 🔬 This issue needs UX design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants