New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a wallet table: fade icons in and out when dropdown select is changed #7371
Conversation
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 12m |
Open to changing the timing of this animation. Some user feedback from user testing suggested that the compare features didn't seem like they were doing anything because the icons weren't updating (they were, just didn't look like it since they didn't change). This adds a fade-in and out animation to give the appearance of things changing, even if it's just going from true for one feature to true for another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :-)
Agree on changing the timing... it feels a little too dramatic as is 😅.
Also left a comment about us picking an animation convention and but not necessarily a blocker to this PR.
import { getImage, GatsbyImage } from "gatsby-plugin-image" | ||
import { keyframes } from "@emotion/react" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we decide on a convention of how we animate (maybe framer-motion?) on ethereum.org?
We now have at least three ways to animate:
- motion components
- CSS animations
- keyframes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I know that we use framer for a lot of other animations so will refactor to that.
Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@nloureiro or @konopkja to review?
looks good to me |
Just to be sure, are we working on this fading? fading.icons.movIf yes, it looks good! |
@nloureiro yes :-)! thanks guys, merged! |
Description