Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed broken link and fixed incorrect id in url #7643

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

SavPhill
Copy link
Contributor

@SavPhill SavPhill commented Sep 1, 2022

Removed link on line 520 which was broken - http://sourceforge.net/p/bitcoin/mailman/message/31709140/.

Edited the url of the wikipedia to reflect the correct scroll to it for Simplified Payment Verification.
From https://en.bitcoin.it/wiki/Scalability#Simplifiedpaymentverification to https://en.bitcoin.it/wiki/Scalability#Simplified_payment_verification

Description

  1. Fixing a broken link to a resource which is no longer available.
  2. Editing the url of a link to make the id instantly accessible.

Related Issue

  1. Visit the link titled Peter Todd on Merkle sum trees on point 21 of Further Reading: http://sourceforge.net/p/bitcoin/mailman/message/31709140/
    It is no longer accessible.
  2. Visit the link titled Simplified payment verification on point 13 of further reading: https://en.bitcoin.it/wiki/Scalability#Simplified_payment_verification. The scroll to ID is incorrect and it opens the top of the page, which makes the link appear incorrect initially for the user.

@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ethereum-org-website ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 5:22PM (UTC)

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Sep 1, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 1, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 11m

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SavPhill, thanks for catching this.

We decided that we would not be alterating the Whitepaper (checkout #3794 for context), apart from fixing things that are broke. So we'd definitely want to keep the Peter Todd further reading link.

Luckily, we have a web archive version of the Peter Todd on Merkle sum trees that we can use instead: https://web.archive.org/web/20140623061815/http://sourceforge.net/p/bitcoin/mailman/message/31709140/

Added the correct link for point 21 according to review request on ethereum#7643
@SavPhill
Copy link
Contributor Author

SavPhill commented Sep 6, 2022

Hey @SavPhill, thanks for catching this.

We decided that we would not be alterating the Whitepaper (checkout #3794 for context), apart from fixing things that are broke. So we'd definitely want to keep the Peter Todd further reading link.

Luckily, we have a web archive version of the Peter Todd on Merkle sum trees that we can use instead: https://web.archive.org/web/20140623061815/http://sourceforge.net/p/bitcoin/mailman/message/31709140/

Thank you- new commit made with the edit:

a3a7a49

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these broken links @SavPhill!

@corwintines
Copy link
Member

@all-contributors can you add @SavPhill for docs

@allcontributors
Copy link
Contributor

@corwintines

I've put up a pull request to add @SavPhill! 🎉

@corwintines corwintines merged commit d160d8a into ethereum:dev Sep 8, 2022
@corwintines corwintines mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants