Fix two Spanish sentences on homepage #7673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 29m |
pettinarip
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Gracias por el PR @ldlsalazar 💪🏼
Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳!
|
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
|
@all-contributors please add @ldlsalazar for translations |
|
I've put up a pull request to add @ldlsalazar! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was reading the homepage and came across two sentences I would consider incorrect. As a native Spanish speaker they did not make sense to me, so I compared it to the English homepage to understand what you were trying to say.
Here in English you wrote "it helps to have a guide" but in Spanish if you say "un guía", that means a person that helps. Changing it to "una guía" means that you need a document/object to guide you; which is what I think you were trying to say.
Here the sentence in English has the word "wherever" which translates to the word/phrase donde sea. The phrase "donde sea" means no matter where, so using "sin importar" the translation of no matter what/where makes more sense.