TS - Fix Gatsby image type #7702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 16m |
pettinarip
commented
Sep 6, 2022
| @@ -89,15 +89,16 @@ const ActionCard: React.FC<IProps> = ({ | |||
| isRight, | |||
| isBottom = true, | |||
| }) => { | |||
| const isImageURL = typeof image === "string" && image.includes("http") | |||
| const isImageURL = typeof image === "string" | |||
There was a problem hiding this comment.
Simplifying this condition. Any sort of string must be passed to an html img tag.
pettinarip
commented
Sep 6, 2022
| isSvg = true | ||
| } | ||
| } | ||
| const isImgSrc = typeof image === "string" |
There was a problem hiding this comment.
If image is a string just pass it to the img tag since GatsbyImage can't process it anyway.
Furthermore, in all the instances where we are using ProductCard, we are not sending a string. Only Gatsby image instances.
pettinarip
requested review from
samajammin,
wackerow,
corwintines,
minimalsm and
jmcook1186
as code owners
minimalsm
approved these changes
Sep 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement correct types for Gatsby images.
The native
getImageandgetSrcGatsby functions do not play very well with the types generated by GraphQL Typegen.The Gatsby team has improved a bit these functions but they still do not support null values.
In this PR, I've created a custom wrapper to deal with the null cases.
Most of the changes you see here are just:
getImageandgetSrcfunctionsstringbefore. These are:ImageDataLike=> data shape returned by the graphql queryIGatsbyImageData=> data shape returned by thegetImagefunction