Refactor CallToContribute component
#8372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
github-actions
bot
added
the
needs review 👀
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
approved these changes
Oct 29, 2022
|
@pettinarip certainly! I have not found anything yet that leads me to believe otherwise without deleting that old config file |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
CallToContributepost Chakra migration.ContentColumnreusable component for the image and the content.Showcomponent to only show the image above thelgbreakpoint (see additional information below).DescriptionParagraphreusable component for the content paragraphs.Related Issue
N/A
Additional Information
As of this PR, the Chakra UI migration is not complete. If I were to do the following with
Show:The token value would not be recognized. This is due to the under the hood functionality of
Showusing theuseThemehook from Chakra.useThemelooks through the emotion package to retrieve theme values from the Context, and I believe it is receiving the old theme config instead of the Chakra config. Indeed there is no issue when applying Chakra's token values in the style props (I believe it has to do with how the theme config is acquired different fromuseTheme)useTokensolves this issue temporarily until the complete merge occurs.