Update Matomo tracking eventValue for QuizWidget #8441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send "1" for correct answer, "0" for incorrect
wackerow
requested review from
samajammin,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
samajammin
reviewed
Nov 9, 2022
| eventValue: answer.isCorrect | ||
| ? `Correct answer` | ||
| : `AID: ${answer.answerId}`, | ||
| eventValue: answer.isCorrect ? "1" : "0", |
There was a problem hiding this comment.
Does string vs. integer matter here?
There was a problem hiding this comment.
Without looking at docs or other implementations we've done, my gut thinks these should be integers.
There was a problem hiding this comment.
The eventValue type is currently set up to accept a string... We could try updating the interface to accept a number, we should just make sure this passes appropriately to Matomo.
This should still fix the issue on Matomo side of just being able to split these into two categories.
|
@wackerow @samajammin can we push this forward? |
corwintines
approved these changes
Nov 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
None filed, request per @konopkja