-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an overview of how a transaction gets executed in Ethereum PoS [Fixes #8546] #8548
Add an overview of how a transaction gets executed in Ethereum PoS [Fixes #8546] #8548
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is a good addition - thanks. I have suggested some changes that I think make the description a bit more clear and precise in places. Pinging @wackerow to take a look too if he has time.
Co-authored-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
Thanks a lot for adding the additional information and making the process clearer. |
src/content/developers/docs/consensus-mechanisms/pow/mining/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danceratopz!
@all-contributors can you add @danceratopz for content |
I've put up a pull request to add @danceratopz! 🎉 |
Nice suggestion @danceratopz! Be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. We are in the process of getting our 2023 POAPs ready, but once they are you can claim yours also 🥳! |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Thanks @corwintines and @jmcook1186 for the big improvements on the original text. Stoked to see this merged and love the gitpoap! |
This PR adds a section with a top-level overview of how a transaction gets executed in Ethereum PoS to /developers/docs/consensus-mechanisms/pos/index.md.
Description
This new section is analogous to the existing one for Ethereum PoW in developers/docs/consensus-mechanisms/pow/index.md.
Related Issue
This PR fixes the feature requests in #8546.
Grateful for any feedback, suggestions or corrections!