Update DocLink component (Post Chakra)
#8579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
approved these changes
Nov 21, 2022
pettinarip
reviewed
Nov 21, 2022
| _hover={{ | ||
| background: "tableBackgroundHover", | ||
| borderRadius: "base", | ||
| boxShadow: `0 0 1px ${linkBoxShadowColor}`, |
There was a problem hiding this comment.
I like a lot more this way than using the css var
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Boxwrapping all components and send its props toLinkBoxposition='relative'from aFlexcomponent that preventing the whole component from being clickable.useTokento use a theme token in theboxShadowprop instead of a CSS Variablerole="group"as it is invalid to the accessibility of this component (it's a single item, not a group of items)Related Issue
N/A