Refactor: Migrate StakingProductsCardGrid to Chakra
#8679
Conversation
TylerAPfledderer
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
github-actions
bot
added
the
needs review 👀
✅ ethereum-org-website-dev deploy preview ready
|
| maxH={24} | ||
| > | ||
| {!!Svg && <Icon as={Svg} fontSize="2rem" />} | ||
| <Heading fontSize="2xl" color="white" fontWeight="normal"> |
There was a problem hiding this comment.
I think we want to keep the wider font style in here to keep the same styles we had before
| <Heading fontSize="2xl" color="white" fontWeight="normal"> | |
| <Heading fontSize="2xl" color="white"> |
There was a problem hiding this comment.
If this was implemented to fix the headers' height inconsistency I don't think this fixes all of them. We have larger texts like in this case:
I think we can tackle that specific issue on a different PR and/or discuss it with the design team as well.
There was a problem hiding this comment.
Got it. Agreed, I can see a possible quick alteration with the grid to overcome this text wrapping, but it's definitely better with it's own PR and design team input.
There was a problem hiding this comment.
Change of font weight was not intended to fix the header height. I removed the fontWeight prop.
| } | ||
| } | ||
|
|
||
| const StakingPill: React.FC<{ type: string; children: ReactNode }> = ({ |
| <ul> | ||
| </Flex> | ||
| <Box {...PADDED_DIV_STYLE} py={0}> | ||
| <List m={0} gap={3}> |
| @@ -564,11 +538,16 @@ const StakingProductCardGrid: React.FC<IProps> = ({ category }) => { | |||
| if (!rankedProducts) return null | |||
|
|
|||
| return ( | |||
| <CardGrid> | |||
| <SimpleGrid | |||
TylerAPfledderer
deleted the
refactor/staking-products-card-grid-chakra
branch
Description
Migrate the
StakingProductsCardGridcomponent to Chakra UIRelated Issue
#8632