Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade isort #68

Merged
merged 3 commits into from Oct 4, 2022
Merged

Upgrade isort #68

merged 3 commits into from Oct 4, 2022

Conversation

carver
Copy link
Collaborator

@carver carver commented Sep 22, 2022 •
edited

What was wrong?

#65 added black, but missed an isort upgrade. black requires isort v5.

How was it fixed?

Upgrade isort to v5, drop the --recursive flag, plus a minor cleanup to flake8 and tox.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@carver carver requested a review from fselmo September 22, 2022 20:44
@carver
Copy link
Collaborator Author

carver commented Sep 22, 2022

I think @kclowes is on a break, so maybe @fselmo could review, since you looked at the last related PR? It's quite small

@carver
Fix a copy-paste mistake from ethereum#65
4bd0240 
toxinidir won't mean anything in a Makefile
fselmo
fselmo approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@fselmo fselmo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm 👌🏼

@carver carver merged commit c802e5d into ethereum:master Oct 4, 2022
@carver carver deleted the upgrade-isort branch October 5, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carver @fselmo