Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to uses lists of configs, both with resources and files #1169

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Adding ability to uses lists of configs, both with resources and files #1169

merged 3 commits into from
Sep 5, 2018

Conversation

zilm13
Copy link
Collaborator

@zilm13 zilm13 commented Sep 4, 2018

We need this feature badly, for example, for Harmony.

@zilm13 zilm13 requested a review from mkalinin September 4, 2018 23:15
@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 56.349% when pulling 53f52c0 on feature/config-list into 5474319 on develop.

mkalinin
mkalinin suggested changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pretty useful change 👍
Let's, also, add an example to README.md of how users can benefit from such a nice feature.

ethereumj-core/src/test/java/org/ethereum/config/SystemPropertiesTest.java
}

@Test
public void testMergeConfigs3() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lacks of test case with different properties that are eventually merged into single configuration.

@mkalinin mkalinin merged commit 5c808c1 into develop Sep 5, 2018
@zilm13 zilm13 deleted the feature/config-list branch September 20, 2018 09:11
@mkalinin mkalinin added this to the 1.9.0-Constantinople milestone Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkalinin mkalinin mkalinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0-Constantinople
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zilm13 @coveralls @mkalinin