VM hook redesign (optimized) #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 18, 2018 16:55
zilm13
approved these changes
Sep 20, 2018
| @@ -1412,7 +1430,7 @@ public void play(Program program) { | |||
| @Deprecated | |||
| public static void setVmHook(VMHook vmHook) { | |||
| logger.warn("VM.setVmHook(VMHook vmHook) is deprecated method. Define your hook component as a Spring bean."); | |||
There was a problem hiding this comment.
I think we should add line that it will affect only new VM instances
There was a problem hiding this comment.
What do you mean? Could you explain more detailed?
There was a problem hiding this comment.
Ahh ok, it looks like a very old code and as it's going to be deprecated, not an isuue
mkalinin
approved these changes
Sep 20, 2018
Nashatyrev
approved these changes
Sep 21, 2018
|
|
||
| @Autowired | ||
| public RootVmHook(Optional<List<VMHook>> hooks) { | ||
| this.hooks = hooks.orElseGet(ArrayList::new); | ||
| public RootVmHook(Optional<VMHook[]> hooks) { |
There was a problem hiding this comment.
Not a blocker, but I would prefer using List instead of arrays as far as it's not critical. As soon as we added hasHooks flag this place is no more performance critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds performance optimization on proxy calls to nested and deprecated VM hooks.
Adds VM hooks testing support via
StandaloneBlockchain.Increases SpringFramework version up to
4.3.19.RELEASE.