[WIP] Attestation committees #1185
Conversation
| return; | ||
|
|
||
| // get number of the next slot that validator is eligible to propose | ||
| long slotNumber = calcNextProposingSlot(proposer.getSlotNumber(System.currentTimeMillis()), |
There was a problem hiding this comment.
Let's move System.currentTimeMillis() somewhere to one source, as sharding logic is dependant of time and we may need some accuracy tweaks for it in future or whatever.
There was a problem hiding this comment.
I think adding getCurrentSlot() method to BeaconProposer should manage that
| // each committee dedicated for own shard | ||
| int shard = startShard; | ||
| for (Committee[] slot : committees) { | ||
| for (Committee committee : slot) { |
There was a problem hiding this comment.
slot.length == SHARD_COUNT ?
There was a problem hiding this comment.
nope, slot.length == CYCLE_LENGTH
There was a problem hiding this comment.
Sorry, slot.length depends on the size of active validator set. It varies from 1 to (1 << 24) / CYCLE_LENGTH / (MIN_COMMITTEE_SIZE * 2) + 1, it's calculated with ShufflingCommitteeFactory#calcShardsPerSlot()
| public void testShuffle() { | ||
| int[] in = IntStream.range(1, BeaconConstants.MIN_COMMITTEE_SIZE * 1024).toArray(); | ||
| int[] out = new ShufflingCommitteeFactory().shuffle(HashUtil.randomHash(), in); | ||
| assertFalse(Arrays.equals(in, out)); |
There was a problem hiding this comment.
yep, in theory it may be, but hardly the case in practice :)
There one thing worth to add before the merge. Proposer service schedules each slot in current implementation, it should be linked to committees transition to only produce blocks for slots it assigned to.
Resolves #1142