Added Milagro crypto-library with BLS12-381 implementation. #1236
Conversation
…t of message signing added.
|
@mkalinin ready for review |
|
resolves #1237 |
| */ | ||
| public interface BLS381 { | ||
|
|
||
| BI generatePrivate(); |
There was a problem hiding this comment.
I think naming is a bit incomplete cause it doesn't point that generation has PRNG kind.
|
|
||
| BI generatePrivate(); | ||
|
|
||
| BI restorePrivate(BigInteger value); |
There was a problem hiding this comment.
I would abstract from any particular big number implementation. Wouldn't byte[] representation be sufficient enough?
|
|
||
| BI restorePrivate(BigInteger value); | ||
|
|
||
| BI restorePrivate(byte[] value); |
There was a problem hiding this comment.
It seems that this method addresses more general case than restoring just private keys. Maybe it's better to call it restoreScalar?
|
|
||
| FP12Point pair(ECP2Point pointECP2, ECP1Point pointECP1); | ||
|
|
||
| interface BI { |
| FP12Point pair(ECP2Point pointECP2, ECP1Point pointECP1); | ||
|
|
||
| interface BI { | ||
| BigInteger asBigInteger(); |
There was a problem hiding this comment.
Should be removed in case if we're not sticking with any specific big number implementations
| byte[] asByteArray(); | ||
| } | ||
|
|
||
| interface ECP1Point { |
There was a problem hiding this comment.
I think ECP1 or even P1 would be pretty enough here
| byte[] asByteArray(); | ||
| } | ||
|
|
||
| interface FP12Point {} |
There was a problem hiding this comment.
This is not a point, actually. Let's call it FP12. And I would, also, explicitly add equals method to that interface to point it out as an expecting one from underlying implementations
| @@ -36,24 +44,30 @@ | |||
| BigInteger aggPubs(List<BigInteger> pubKeys); | |||
|
|
|||
| class Signature { | |||
| public BigInteger r; | |||
| public BigInteger s; | |||
| public BigInteger value; | |||
There was a problem hiding this comment.
It doesn't look to me that having Signature class is something useful. Maybe turn it into byte[]?
| @@ -36,24 +44,30 @@ | |||
| BigInteger aggPubs(List<BigInteger> pubKeys); | |||
There was a problem hiding this comment.
This method looks redundant. pubKeys may be passed to verify directly.
...First test of message signing added.
Not ready for merge yet, a lot of work to go.