Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add ABI version to the documentation #271

Merged
merged 1 commit into from May 9, 2019
Merged

docs: add ABI version to the documentation #271

merged 1 commit into from May 9, 2019

Conversation

axic
Copy link
Member

@axic axic commented May 8, 2019

Couldn't yet get bumpversion to work properly.

chfast
chfast reviewed May 9, 2019
View reviewed changes
.bumpversion.cfg Outdated Show resolved Hide resolved
docs/EVMC.md Outdated Show resolved Hide resolved
@axic axic marked this pull request as ready for review May 9, 2019 09:55
@axic
Copy link
Member Author

axic commented May 9, 2019

@chfast this seems to be working now, please double check.

chfast
chfast requested changes May 9, 2019
View reviewed changes
Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it works now.
Looks like parse is not needed so can you remove it also from [bumpversion:file:include/evmc/evmc.h] section?

I still don't understand why replace is needed here but not in sections for rust packages.

@axic
Copy link
Member Author

axic commented May 9, 2019

Updated.

@axic axic merged commit 912d875 into master May 9, 2019
@axic axic deleted the docs-version branch May 9, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@axic @chfast